Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hoverable prop from Checkbox #2092

Merged
merged 4 commits into from
May 8, 2024
Merged

Conversation

laurakwhit
Copy link
Contributor

Description & motivation πŸ’­

Updates the following on the Checkbox component

  • Removes unused hoverable prop
  • Uses parent background color for border color on hover/focus instead of white or black
  • Doesn't show hover/focus state when disabled

Screenshots (if applicable) πŸ“Έ

Before After
Screenshot 2024-05-07 at 2 54 27β€―PM Screenshot 2024-05-07 at 2 59 00β€―PM
Screenshot 2024-05-07 at 2 54 46β€―PM Screenshot 2024-05-07 at 2 58 42β€―PM

Design Considerations 🎨

Testing πŸ§ͺ

How was this tested πŸ‘»

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: πŸšΆπŸ½β€β™‚οΈπŸšΆπŸ½β€β™€οΈ

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
holocene βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 7, 2024 9:13pm

@laurakwhit laurakwhit merged commit 96af884 into main May 8, 2024
10 checks passed
@laurakwhit laurakwhit deleted the remove-checkbox-hoverable branch May 8, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants