Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove csp meta tag if publicPath exists and log warning #2103

Merged
merged 1 commit into from
May 9, 2024

Conversation

Alex-Tideman
Copy link
Contributor

@Alex-Tideman Alex-Tideman commented May 9, 2024

Description & motivation πŸ’­

If TEMPORAL_UI_PUBLIC_PATH is provided, remove the meta tag that contains content security policy and log warning

Screenshots (if applicable) πŸ“Έ

Screen Shot 2024-05-09 at 3 40 33 PM Screen Shot 2024-05-09 at 3 41 04 PM

Design Considerations 🎨

Testing πŸ§ͺ

How was this tested πŸ‘»

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: πŸšΆπŸ½β€β™‚οΈπŸšΆπŸ½β€β™€οΈ

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@Alex-Tideman Alex-Tideman requested a review from a team as a code owner May 9, 2024 20:43
@Alex-Tideman Alex-Tideman requested review from KATIETOLER and removed request for a team May 9, 2024 20:43
Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
holocene βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback May 9, 2024 8:43pm

@Alex-Tideman Alex-Tideman requested review from stevekinney, GiantRobots and rossedfort and removed request for KATIETOLER May 9, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants