Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time buttons doesn't fire input event #42

Closed
kamilj opened this issue Dec 30, 2017 · 4 comments
Closed

time buttons doesn't fire input event #42

kamilj opened this issue Dec 30, 2017 · 4 comments

Comments

@kamilj
Copy link

kamilj commented Dec 30, 2017

#As example.
If you enter data into the text field, the event will be fired.
If you press buttons in the datetimepicker, events will not be fired.

https://jsfiddle.net/pbLxedap/2/

@William-H-M
Copy link

Maybe you should take a look at this https://tempusdominus.github.io/bootstrap-4/Events/#changedatetimepicker

@cthiebaud
Copy link
Contributor

I believe the test at ~ line 556 of https://github.com/tempusdominus/bootstrap-4/blob/master/build/js/tempusdominus-bootstrap-4.js

would be more correct - and readable - with parenthesis :

for e.g. e = {type: "datetimepicker.show"}

e.type === DateTimePicker.Event.CHANGE && e.date && e.date.isSame(e.oldDate) || !e.date && !e.oldDate
-> true -> then the function returns and does not fire the event 👎
e.type === DateTimePicker.Event.CHANGE && ((e.date && e.date.isSame(e.oldDate)) || (!e.date && !e.oldDate))
-> false 👍

@kamilj
Copy link
Author

kamilj commented Jun 3, 2018

It still does not work.
https://jsfiddle.net/6h1ak85w

@Eonasdan
Copy link
Contributor

Eonasdan commented Jul 7, 2018

@kamilj your fiddle has console errors. please let me know if it still doesn't work with the latest BS and picker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants