Set Tenscan listing totals to overall counts #1972
Merged
+49
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badgersrus
changed the title
BedrockSquirrel
approved these changes
Jul 4, 2024
go/host/storage/hostdb/rollup.go
Outdated
| err := db.QueryRow(selectLatestRollupCount).Scan(&total) | ||
| if err != nil { | ||
| if errors.Is(err, sql.ErrNoRows) { | ||
| return nil, errutil.ErrNotFound |
There was a problem hiding this comment.
Return zero rather than error here imo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this change is needed
https://github.com/ten-protocol/ten-internal/issues/3539
What changes were made as part of this PR
/items/transactions/now returns the result from thetransaction_counttable as the total/items/batches/now uses the latest sequence number as the total count/items/rollups/now returns the last index on therollup_hosttablePlease provide a high level list of the changes made
PR checks pre-merging
Please indicate below by ticking the checkbox that you have read and performed the required
PR checks