Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Use module instance name for download directory #672

Closed
MrMickS opened this issue Apr 16, 2021 · 0 comments · Fixed by #774
Closed

Enhancement: Use module instance name for download directory #672

MrMickS opened this issue Apr 16, 2021 · 0 comments · Fixed by #774
Assignees
Projects

Comments

@MrMickS
Copy link

MrMickS commented Apr 16, 2021

Using a build from master, with the code to download private modules from Terraform Cloud, I was able to get the following results from terrascan:

Violation Details -
    
	Description    :	Ensure CloudWatch logging is enabled for Route53 hosted zones.
	File           :	../tmp/vgfgfm/main.tf
	Line           :	235
	Severity       :	MEDIUM
	-----------------------------------------------------------------------
	
	Description    :	Ensure VPC flow logging is enabled in all VPCs
	File           :	../tmp/vgfgfm/main.tf
	Line           :	58
	Severity       :	MEDIUM
	-----------------------------------------------------------------------
	
	Description    :	Like any other EC2 instance it is recommended to place ECS instance within a VPC. AWS VPCs provides the controls to facilitate a formal process for approving and testing all network connections and changes to the firewall and router configurations
	File           :	../tmp/lahpo5/main.tf
	Line           :	547
	Severity       :	HIGH
	-----------------------------------------------------------------------
	
	Description    :	http port open to internet
	File           :	../tmp/lahpo5/main.tf
	Line           :	82
	Severity       :	HIGH
	-----------------------------------------------------------------------

The scan works well but the File path is less helpful when it comes to working out which module inclusion has raised the issue.

It would be useful to have either the module name, or the module instance, as the path instead of the random unique value used.

@patilpankaj212 patilpankaj212 added this to To do in Main Board via automation May 12, 2021
@patilpankaj212 patilpankaj212 moved this from To do to In progress in Main Board May 12, 2021
@patilpankaj212 patilpankaj212 moved this from In progress to Review in progress in Main Board May 12, 2021
@patilpankaj212 patilpankaj212 linked a pull request May 12, 2021 that will close this issue
Main Board automation moved this from Review in progress to Done May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants