Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for module name in violation summary #774

Conversation

patilpankaj212
Copy link
Contributor

  1. adds support for accommodating module_name in the violation summary and resource config output, for terraform iac type.
  2. For root modules, the module_name would be root
  3. For file scans, module_name will default to root

@sonarcloud
Copy link

sonarcloud bot commented May 12, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #774 (77b2ba2) into master (01c8d78) will decrease coverage by 0.01%.
The diff coverage is 82.35%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #774      +/-   ##
==========================================
- Coverage   73.78%   73.77%   -0.02%     
==========================================
  Files         110      110              
  Lines        3285     3294       +9     
==========================================
+ Hits         2424     2430       +6     
- Misses        677      679       +2     
- Partials      184      185       +1     
Impacted Files Coverage Δ
pkg/iac-providers/output/types.go 100.00% <ø> (ø)
pkg/results/types.go 100.00% <ø> (ø)
pkg/writer/human_readable.go 78.68% <0.00%> (-4.08%) ⬇️
pkg/iac-providers/terraform/commons/load-dir.go 84.55% <100.00%> (+0.46%) ⬆️
pkg/iac-providers/terraform/commons/load-file.go 92.30% <100.00%> (+0.30%) ⬆️
pkg/policy/opa/engine.go 65.57% <100.00%> (+0.14%) ⬆️

@kanchwala-yusuf kanchwala-yusuf merged commit cb2be19 into tenable:master May 17, 2021
@patilpankaj212 patilpankaj212 deleted the enhancement-module-name-terraform branch May 18, 2021 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Use module instance name for download directory
2 participants