Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reading .terraformrc file from env var #1264

Merged
merged 1 commit into from
May 19, 2022

Conversation

Rchanger
Copy link
Contributor

To download terraform modules from a private registry we need credentials, terrascan supports reading credentials file from the home directory. Terraform also allows to pass that credentials file location via env variable TF_CLI_CONFIG_FILE , added support for that env variable in terrascan

@Rchanger Rchanger requested a review from a team as a code owner May 19, 2022 11:47
@sonarcloud
Copy link

sonarcloud bot commented May 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov-commenter
Copy link

Codecov Report

Merging #1264 (f3b737c) into master (feb646a) will decrease coverage by 0.04%.
The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1264      +/-   ##
==========================================
- Coverage   77.42%   77.37%   -0.05%     
==========================================
  Files         272      272              
  Lines        7725     7731       +6     
==========================================
+ Hits         5981     5982       +1     
- Misses       1386     1390       +4     
- Partials      358      359       +1     
Impacted Files Coverage Δ
pkg/downloader/module-download.go 79.67% <16.66%> (-3.24%) ⬇️

Copy link
Contributor

@patilpankaj212 patilpankaj212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cesar-rodriguez
Copy link
Contributor

Can we add the corresponding PR on the documentation repo, please? https://github.com/tenable/runterrascan.io

@Rchanger
Copy link
Contributor Author

Rchanger commented May 19, 2022

Can we add the corresponding PR on the documentation repo, please? https://github.com/tenable/runterrascan.io

Yes, creating one tenable/runterrascan.io#68

@Rchanger Rchanger merged commit 48b6393 into tenable:master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants