Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed typo of the function name #1373

Merged
merged 6 commits into from
Oct 12, 2022
Merged

Conversation

Antsaniaina
Copy link
Contributor

Fixed a typo in the Encryption Function name.

@Antsaniaina Antsaniaina requested a review from a team as a code owner August 25, 2022 19:00
@gaurav-gogia gaurav-gogia added the policy Issue concerning policy maintainers. label Aug 25, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1373 (e95a510) into master (313ccf3) will decrease coverage by 0.01%.
The diff coverage is 37.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1373      +/-   ##
==========================================
- Coverage   77.39%   77.38%   -0.02%     
==========================================
  Files         277      277              
  Lines        7813     7817       +4     
==========================================
+ Hits         6047     6049       +2     
- Misses       1406     1407       +1     
- Partials      360      361       +1     
Impacted Files Coverage Δ
...ders/terraform/commons/extract-container-images.go 78.63% <25.00%> (ø)
.../mapper/iac-providers/cft/config/dynamodb-table.go 87.50% <50.00%> (-12.50%) ⬇️

Copy link
Contributor

@gaurav-gogia gaurav-gogia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some edge cases have been missed here

  • encryption_settings is an array block
  • when empty, encryption_settings may return config in this format [{}]

@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@gaurav-gogia gaurav-gogia merged commit baf1dfd into tenable:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
policy Issue concerning policy maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants