Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accurics.gcp.IAM.104 Fire rule when client certificate is enabled #402

Merged
merged 5 commits into from
Nov 24, 2020

Conversation

lucas-giaco
Copy link
Contributor

Hi folks, this is my first contribution to the project and my first time with rego rules, so thanks in advance for your patience.
I'm trying to fix the clientCertificateEnabled rule to be fired only the client certificate is enabled.

This PR should solve #330

@codecov
Copy link

codecov bot commented Nov 22, 2020

Codecov Report

Merging #402 (66c14cd) into master (55a6c2c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #402   +/-   ##
=======================================
  Coverage   63.55%   63.55%           
=======================================
  Files          85       85           
  Lines        1904     1904           
=======================================
  Hits         1210     1210           
  Misses        591      591           
  Partials      103      103           

Copy link
Contributor

@cesar-rodriguez cesar-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@sonarcloud
Copy link

sonarcloud bot commented Nov 24, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants