Fix: potential bug added in PR #470 #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devang-gaur
requested review from
amirbenv,
patilpankaj212 and
kanchwala-yusuf
Codecov Report
@@ Coverage Diff @@
## master #497 +/- ##
=======================================
Coverage 73.69% 73.69%
=======================================
Files 93 93
Lines 2148 2148
=======================================
Hits 1583 1583
Misses 429 429
Partials 136 136
|
|
Kudos, SonarCloud Quality Gate passed!
|
kanchwala-yusuf
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My PR #470 wrongly set the default version for terraform iac to v14 from v12, in the context of policy engine. Everywhere else in the repo, the default version is still v12 for terraform. So this PR will rectify the mistake and eliminate any potential bug caused due to this.