Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accurics.azure.AKS.3 #712

Merged
merged 1 commit into from
May 17, 2021
Merged

Conversation

xortim
Copy link
Contributor

@xortim xortim commented Apr 29, 2021

Resolves #711

@amirbenv
Copy link
Contributor

Thanks for the fix! will review shortly

@sonarcloud
Copy link

sonarcloud bot commented May 3, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@devang-gaur devang-gaur added the policy Issue concerning policy maintainers. label May 4, 2021
@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #712 (88b0f1b) into master (a09b879) will increase coverage by 0.50%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #712      +/-   ##
==========================================
+ Coverage   73.28%   73.78%   +0.50%     
==========================================
  Files         110      110              
  Lines        3099     3285     +186     
==========================================
+ Hits         2271     2424     +153     
- Misses        650      677      +27     
- Partials      178      184       +6     
Impacted Files Coverage Δ
...ac-providers/terraform/commons/local-references.go 71.87% <0.00%> (-8.13%) ⬇️
pkg/iac-providers/kubernetes/v1/load-dir.go 67.74% <0.00%> (-4.68%) ⬇️
pkg/writer/human_readable.go 82.75% <0.00%> (-4.04%) ⬇️
...providers/terraform/commons/variable-references.go 78.46% <0.00%> (-3.51%) ⬇️
pkg/iac-providers/helm/v3/load-dir.go 82.89% <0.00%> (-2.73%) ⬇️
pkg/iac-providers/kustomize/v3/load-dir.go 71.69% <0.00%> (-2.31%) ⬇️
pkg/iac-providers/kubernetes/v1/normalize.go 88.05% <0.00%> (-2.31%) ⬇️
...c-providers/terraform/commons/module-references.go 40.00% <0.00%> (-2.11%) ⬇️
pkg/policy/opa/engine.go 65.43% <0.00%> (-0.13%) ⬇️
pkg/cli/run.go 91.42% <0.00%> (ø)
... and 12 more

Copy link
Contributor

@harkirat22 harkirat22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harkirat22 harkirat22 merged commit 72e3ebc into tenable:master May 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
policy Issue concerning policy maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

accurics.azure.AKS.3 is defective
4 participants