Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webhook setup capability and remote repo scan capability in the helm charts #778

Merged
merged 6 commits into from
May 18, 2021

Conversation

devang-gaur
Copy link
Contributor

@devang-gaur devang-gaur commented May 12, 2021

@codecov
Copy link

codecov bot commented May 12, 2021

Codecov Report

Merging #778 (46b1d02) into master (53eda39) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #778   +/-   ##
=======================================
  Coverage   74.88%   74.88%           
=======================================
  Files         110      110           
  Lines        3309     3309           
=======================================
  Hits         2478     2478           
  Misses        646      646           
  Partials      185      185           

@devang-gaur devang-gaur changed the title add remote repo scan capability in the helm chart Add webhook setup capability and remote repo scan capability in the helm charts May 14, 2021
@@ -0,0 +1,59 @@
apiVersion: admissionregistration.k8s.io/v1beta1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

admissionregistration.k8s.io/v1 is available, should we not use that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted.

deploy/helm-charts/README.md Outdated Show resolved Hide resolved
deploy/helm-charts/README.md Show resolved Hide resolved
@devang-gaur devang-gaur force-pushed the helm_chart branch 3 times, most recently from bad0960 to 63f5070 Compare May 18, 2021 06:03
@sonarcloud
Copy link

sonarcloud bot commented May 18, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@Rchanger Rchanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devang-gaur devang-gaur merged commit 1d7e5b9 into tenable:master May 18, 2021
@devang-gaur devang-gaur added this to Done in Main Board Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants