Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multierror variable issue #818

Merged
merged 1 commit into from
May 28, 2021

Conversation

patilpankaj212
Copy link
Contributor

Fixed - The multierror variable in load-dir.go files of helm, kustomize and k8s iac providers should not be a package level variable.

@sonarcloud
Copy link

sonarcloud bot commented May 27, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #818 (d3b8a9e) into master (a4d7af9) will not change coverage.
The diff coverage is 60.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #818   +/-   ##
=======================================
  Coverage   74.85%   74.85%           
=======================================
  Files         111      111           
  Lines        3345     3345           
=======================================
  Hits         2504     2504           
  Misses        656      656           
  Partials      185      185           
Impacted Files Coverage Δ
pkg/iac-providers/kubernetes/v1/types.go 100.00% <ø> (ø)
pkg/iac-providers/kustomize/v3/types.go 100.00% <ø> (ø)
pkg/iac-providers/helm/v3/load-dir.go 82.89% <50.00%> (ø)
pkg/iac-providers/kubernetes/v1/load-dir.go 67.74% <66.66%> (ø)
pkg/iac-providers/kustomize/v3/load-dir.go 71.69% <66.66%> (ø)

@kanchwala-yusuf kanchwala-yusuf merged commit 23bb0ae into tenable:master May 28, 2021
@patilpankaj212 patilpankaj212 added this to Done in Main Board May 31, 2021
@patilpankaj212 patilpankaj212 deleted the fix-multierror-issue branch May 5, 2022 11:37
@patilpankaj212 patilpankaj212 restored the fix-multierror-issue branch May 5, 2022 11:37
@patilpankaj212 patilpankaj212 deleted the fix-multierror-issue branch May 5, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants