Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ID Field for K8s Policies' Metadata #826

Merged
merged 2 commits into from
Jun 1, 2021

Conversation

Avanti19
Copy link
Contributor

Changes for terrascan policies where names match with SIAC policies

These changes are relevant only for K8s policies

  1. Add id field with new format
  2. Update severity
  3. Update category

@Avanti19 Avanti19 self-assigned this May 31, 2021
@Avanti19 Avanti19 added the policy Issue concerning policy maintainers. label May 31, 2021
@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #826 (d797200) into master (e4ae20c) will increase coverage by 0.12%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #826      +/-   ##
==========================================
+ Coverage   74.87%   74.99%   +0.12%     
==========================================
  Files         111      113       +2     
  Lines        3339     3463     +124     
==========================================
+ Hits         2500     2597      +97     
- Misses        654      675      +21     
- Partials      185      191       +6     
Impacted Files Coverage Δ
pkg/http-server/webhook-scan-logs.go 0.00% <0.00%> (ø)
pkg/http-server/file-scan.go 81.18% <100.00%> (+0.18%) ⬆️
pkg/http-server/health.go 100.00% <100.00%> (ø)
pkg/http-server/remote-repo.go 70.14% <100.00%> (+0.45%) ⬆️
pkg/http-server/webhook-scan.go 70.73% <100.00%> (+0.73%) ⬆️
pkg/config/config-reader.go 80.64% <0.00%> (-6.32%) ⬇️
pkg/utils/severity.go 94.11% <0.00%> (-5.89%) ⬇️
pkg/iac-providers/kubernetes/v1/load-file.go 71.87% <0.00%> (-4.13%) ⬇️
pkg/utils/json.go 68.75% <0.00%> (-2.68%) ⬇️
pkg/policy/opa/engine.go 64.40% <0.00%> (-1.18%) ⬇️
... and 12 more

@sonarcloud
Copy link

sonarcloud bot commented Jun 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Avanti19 Avanti19 merged commit 48f92ef into tenable:master Jun 1, 2021
@gaurav-gogia gaurav-gogia linked an issue Jun 3, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
policy Issue concerning policy maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ID field
3 participants