Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/use ref id old format #846

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Bugfix/use ref id old format #846

merged 2 commits into from
Jun 8, 2021

Conversation

gaurav-gogia
Copy link
Contributor

  • Fixed reference_id for those json files that were using incorrect format
  • These fixed reference_id fields try to use old format as closely as possible

@gaurav-gogia gaurav-gogia added the policy Issue concerning policy maintainers. label Jun 8, 2021
@gaurav-gogia gaurav-gogia self-assigned this Jun 8, 2021
@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #846 (9c3d09b) into master (82e5242) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #846   +/-   ##
=======================================
  Coverage   78.20%   78.20%           
=======================================
  Files         164      164           
  Lines        4359     4359           
=======================================
  Hits         3409     3409           
  Misses        735      735           
  Partials      215      215           

Copy link
Contributor

@nasir-rabbani nasir-rabbani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaurav-gogia gaurav-gogia merged commit 8fc20b2 into tenable:master Jun 8, 2021
@gaurav-gogia gaurav-gogia deleted the bugfix/use_ref_id_old_format branch June 8, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
policy Issue concerning policy maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants