Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add forward compatibility for laravel 5.2 and up #47

Closed
luceos opened this issue Dec 14, 2015 · 8 comments · Fixed by hyn/framework#8
Closed

add forward compatibility for laravel 5.2 and up #47

luceos opened this issue Dec 14, 2015 · 8 comments · Fixed by hyn/framework#8

Comments

@luceos
Copy link
Contributor

luceos commented Dec 14, 2015

No description provided.

@joelcuevas
Copy link

How far is this in the roadmap?

BTW, you have a great package!

@luceos
Copy link
Contributor Author

luceos commented Apr 27, 2016

Hello @joelcuevas. Thank you, I hope it's useful to you as well. Related to this issue, I have had little time these past few months, so it has not been prioritized.

@bkintanar
Copy link
Member

@luceos I know you're busy with https://github.com/flarum/flarum and other projects. But when do you think this would be ready for 5.2+? Or maybe you could point us which files do you think needs change in the https://github.com/hyn/framework.

Thanks!

@luceos
Copy link
Contributor Author

luceos commented Jun 7, 2016

Hello @bkintanar actually I stepped down as Flarum community manager for now due to a switch in job. That's what's consuming my time right now. What I would do is change the version constraint in hyn/framework to match 5.2 and install tenancy on a created project. Then it's up to the tests to point to the issues ; vendor/bin/phpunit should help you with that.

If you are willing to start with this I would be more than inclined to help you out where I can. And my apologies to everyone waiting for this, everything is upside down at this moment 😁

@bkintanar
Copy link
Member

Hi @luceos thank you for your reply and I'm sorry to hear that you're busy than usual. I haven't done anything except modified composer.json and required laravel/framework ~5.2.0. then required laravel/laravel ~5.2.0 in the terminal as what is shown below. I then ran phpunit. So what's next? Do I need to test hyn/webserver as well? But the travis returned build failure on the last build.

This is my result:
screen shot 2016-06-07 at 3 04 31 pm

@luceos
Copy link
Contributor Author

luceos commented Jun 7, 2016

You should probably set up a proper environment where you also include hyn/multi-tenant as a checkout/clone. You can do this by setting up Laravel, then configure your composer.json to have a "repositories - path" key linking to those clones and then require the package. It might be difficult to get this running, but it's certainly possible. I should probably make the package more monolythic.

@luceos
Copy link
Contributor Author

luceos commented Jun 7, 2016

Thank you @bkintanar for doing most of the research! This is D O N E ! Newsletter coming in.

@luceos luceos closed this as completed Jun 7, 2016
@bkintanar
Copy link
Member

Not a problem @luceos. Glad to be of help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants