Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Laravel 10 Support #1036

Merged
merged 17 commits into from
Jul 11, 2023
Merged

Conversation

ArlonAntonius
Copy link
Member

No description provided.

Copy link
Member

@bkintanar bkintanar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jonquintero
Copy link

Hi guys how are you.
Any new change about this update?
Thanks

@PouleR
Copy link
Contributor

PouleR commented Apr 17, 2023

Are you planning to merge this PR so we can update to Laravel 10? Thank you in advance!

@PouleR
Copy link
Contributor

PouleR commented Apr 17, 2023

@ArlonAntonius please note that the usage of the $dates property has been removed.
This is still being used in the Hostname model: protected $dates = ['under_maintenance_since']; and should be rewritten to the casts property:

src/Models/Hostname.php:

protected $casts = [
    'under_maintenance_since' => 'datetime',
];

@PouleR PouleR mentioned this pull request May 31, 2023
@mattvb91
Copy link

mattvb91 commented Jun 3, 2023

any update on this?

@PouleR
Copy link
Contributor

PouleR commented Jun 28, 2023

@ArlonAntonius I've create a PR for you to update this pull request, this should fix the build so we can hopefully merge this.

@jonquintero
Copy link

Hi @PouleR Can you make this works with php 8.2 too ? Thanks

@PouleR
Copy link
Contributor

PouleR commented Jun 28, 2023

Hi @PouleR Can you make this works with php 8.2 too ? Thanks

@jonquintero I just added php-8.2 to the circle ci jobs!

@jonquintero
Copy link

Hi guys, how are you? I want to ask if there is any news about this ?

@PouleR
Copy link
Contributor

PouleR commented Jul 11, 2023

@ArlonAntonius how about merging this PR? Would be really appreciated!

@ArlonAntonius
Copy link
Member Author

You're a hero @PouleR, thanks for all the effort 🚀

@ArlonAntonius ArlonAntonius merged commit 13146f4 into tenancy:5.x Jul 11, 2023
6 checks passed
@mattvb91
Copy link

Thanks @PouleR. Could we also get a tag so we can pull it?

@tvbeek
Copy link

tvbeek commented Jul 27, 2023

@PouleR @ArlonAntonius I'm not sure if you think about this, but this creates a breaking change in a minor release. That is because you drop Laravel 9 support.

Is that intended? Or does there need to be a new PR that bring back the support for Laravel 9.

@ArlonAntonius
Copy link
Member Author

@tvbeek You are completely right, that is a user error and it should be made backward-compatIble. I should have some time this weekend to fix that.
Only thing I am worried about is the PHP versions.

@jonquintero
Copy link

Is not possible to put a tag for laravel 10 support for example 5.9.1 while for laravel 9 you would use something like 5.9.0 ?

@tvbeek
Copy link

tvbeek commented Aug 11, 2023

@jonquintero I'm interested how you see that working for new tags? A 5.10.1 for Laravel 10 and 5.10.0 for Laravel 9? And besides that it is still a breaking change 😃

@ArlonAntonius
Copy link
Member Author

@tvbeek is right, it is a breaking change and should not have been. I have a PR ready in order to add back L9 compatibility. If you guys have ideas, let's move it there :) #1041

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants