-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.x] Laravel 10 Support #1036
[5.x] Laravel 10 Support #1036
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Hi guys how are you. |
Are you planning to merge this PR so we can update to Laravel 10? Thank you in advance! |
@ArlonAntonius please note that the usage of the $dates property has been removed. src/Models/Hostname.php:
|
any update on this? |
@ArlonAntonius I've create a PR for you to update this pull request, this should fix the build so we can hopefully merge this. |
Hi @PouleR Can you make this works with php 8.2 too ? Thanks |
@jonquintero I just added php-8.2 to the circle ci jobs! |
Hi guys, how are you? I want to ask if there is any news about this ? |
@ArlonAntonius how about merging this PR? Would be really appreciated! |
Updates for Laravel 10
You're a hero @PouleR, thanks for all the effort 🚀 |
Thanks @PouleR. Could we also get a tag so we can pull it? |
@PouleR @ArlonAntonius I'm not sure if you think about this, but this creates a breaking change in a minor release. That is because you drop Laravel 9 support. Is that intended? Or does there need to be a new PR that bring back the support for Laravel 9. |
@tvbeek You are completely right, that is a user error and it should be made backward-compatIble. I should have some time this weekend to fix that. |
Is not possible to put a tag for laravel 10 support for example 5.9.1 while for laravel 9 you would use something like 5.9.0 ? |
@jonquintero I'm interested how you see that working for new tags? A 5.10.1 for Laravel 10 and 5.10.0 for Laravel 9? And besides that it is still a breaking change 😃 |
No description provided.