[WIP] POC for SYNC connection support #233
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Line 68 & 69 show a POC way to handle the tenant. There *should* be some additional checks; and we will want to have that configurable... I.E. We have a private array of connection names we check against; that are loaded when this event is thrown Obviously I'm not sure how good of an idea this would be; therefore it is a POC
fletch3555
requested changes
Oct 2, 2021
| @@ -64,7 +65,12 @@ public function __construct(JobProcessing $event) | |||
| $job = $this->unserializeToJob($command); | |||
| } | |||
|
|
|||
| $tenant = $job->getTenant(); | |||
| if ($event->connectionName == "sync" && !is_null(Tenancy::getTenant())) { | |||
There was a problem hiding this comment.
is sync meant to be the name of the connection configuration in the config files? If so, it'd be much better if we could key off of the driver value of sync(https://github.com/laravel/laravel/blob/8.x/config/queue.php#L34) instead of the name since the name could be changed to anything
|
I think what Eric is saying about using the connection driver instead of the name would give us best results. |
|
I'm curious to hear why this is necessary. Aside from it looking like a hack to support |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Line 68 & 69 show a POC way to handle the tenant. There should be some additional checks; and we will want to have that configurable...
I.E.
We have a private array of connection names we check against; that are loaded when this event is thrown
Obviously I'm not sure how good of an idea this would be; therefore it is a proof of concept at this time.
(Please close vs merging)