Provide old tenant in switched event #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.x #263 +/- ##
=========================================
Coverage 98.96% 98.97%
Complexity 290 290
=========================================
Files 98 98
Lines 776 777 +1
=========================================
+ Hits 768 769 +1
Misses 8 8 |
luceos
requested changes
Sep 7, 2022
tests/Framework/Feature/Identification/TenantIdentificationEventsTest.php
Show resolved
Hide resolved
luceos
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's quite a useful information to have in the switched event (if we need to unregister some stuff the previous tenant registered)
Without it we need to statically cache this information in any class that needs it