Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] 文档网站描述中出现 “不相关技术栈” 的使用说明 #77

Closed
Davont opened this issue May 25, 2022 · 3 comments
Closed
Assignees

Comments

@Davont
Copy link

Davont commented May 25, 2022

tdesign-react-starter 版本

最新版

重现链接

https://tdesign.tencent.com/starter/docs/react/deploy

重现步骤

打开官网链接:https://tdesign.tencent.com/starter/docs/react/deploy
React 中使用的 路由插件为 React Router,并非 VueRouter

官网
图片

package.json:

图片

期望结果

建议改成 将 <HashRouter> 改成 <BrowserRouter>:

import * as React from "react";
import * as ReactDOM from "react-dom";
import { BrowserRouter } from "react-router-dom";

ReactDOM.render(
  <BrowserRouter>
    {/* The rest of your app goes here */}
  </BrowserRouter>,
  root
);

参考:https://reactrouter.com/docs/en/v6/routers/browser-router

实际结果

图片

框架版本

React 17.0.2

浏览器版本

No response

系统版本

No response

Node版本

No response

补充说明

似乎文档网站并未开源,无法提 PR。

@Davont Davont changed the title [doc] 文档描述中出现 “不相关技术栈” 的使用说明 [doc] 文档网站描述中出现 “不相关技术栈” 的使用说明 May 25, 2022
@github-actions
Copy link

♥️ 有劳 @xucz 尽快确认问题。
确认有效后将下一步计划和可能需要的时间回复给 @Davont

@uyarn uyarn self-assigned this May 26, 2022
@uyarn
Copy link
Collaborator

uyarn commented May 26, 2022

@Davont 谢谢指正 之前文档改漏了 已经改正了。
另外我们暂时默认使用hash router。因为我们这边的部署比较复杂 用hash router可以减少服务器的一些配置。我们的部署又是基于main分支的最新代码触发web hooks 所以暂时默认的还是使用hash router

@Davont
Copy link
Author

Davont commented May 26, 2022

ok的 ,现在看已经改好了,我把 issue 关闭。

@Davont Davont closed this as completed May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants