Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vod): [116206298] update vod resource #2569

Merged
merged 9 commits into from
Mar 25, 2024
Merged

fix(vod): [116206298] update vod resource #2569

merged 9 commits into from
Mar 25, 2024

Conversation

tongyiming
Copy link
Collaborator

No description provided.

@tongyiming tongyiming changed the title vod update fix(vod): [116206298] update vod resource Mar 22, 2024
@tongyiming tongyiming added run check run check and removed run check run check labels Mar 22, 2024
"preserve_hdr_switch": {
Type: schema.TypeString,
Optional: true,
Default: "OFF",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

后台接口没有设置默认值吗?

@@ -0,0 +1,19 @@
```release-note:enhancement
resource/tencentcloud_vod_adaptive_dynamic_streaming_template: support params vcrf, gop, preserve_hdr_switch, codec_tag; compatible id
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compatible id 是什么意思呢

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的 changelog 我们要不也调整下,改成类似:
resource/tencentcloud_vod_adaptive_dynamic_streaming_template: Add vcrf, gop, preserve_hdr_switch and codec_tag arguments. Adjust resource unique id to xxx.

"codec_tag": {
Type: schema.TypeString,
Optional: true,
Default: "hvc1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的 default 可以去掉吗

"remove_video": {
Type: schema.TypeBool,
Optional: true,
Default: false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的 default 可以去掉吗

"max_video_bitrate": {
Type: schema.TypeInt,
Optional: true,
Default: 0,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里 default 是否可以去掉

"format": {
Type: schema.TypeString,
Optional: true,
Default: "jpg",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的 default 可以去掉吗

@@ -407,6 +542,68 @@ func generateMediaProcessTask(d *schema.ResourceData) (mediaReq *vod.MediaProces
}(item["definition"].(string)),
WatermarkSet: genWatermarkList(item),
MosaicSet: genMosaicList(item),
TraceWatermark: func() *vod.TraceWatermarkInput {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

下面这段逻辑是干嘛的呢,感觉有点复杂

@tongyiming tongyiming added run check run check and removed run check run check labels Mar 25, 2024
@tongyiming tongyiming added run check run check and removed run check run check labels Mar 25, 2024
Copy link
Collaborator

@andrew-tx andrew-tx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrew-tx andrew-tx merged commit 2c57ea4 into master Mar 25, 2024
9 checks passed
@andrew-tx andrew-tx deleted the fix/vod-update branch March 25, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run check run check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants