Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tse): [115375235] support tse network access_control #2581

Merged
merged 4 commits into from
Apr 7, 2024

Conversation

gitmkn
Copy link
Collaborator

@gitmkn gitmkn commented Apr 3, 2024

No description provided.

})
}

const testAccTseCngwNetworkAccessControl = `
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里 lint 检查没有通过

ResourceName: "tencentcloud_tse_cngw_network_access_control.cngw_network_access_control",
ImportState: true,
ImportStateVerify: true,
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

测试用例修改资源的场景没有覆盖

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是个config

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

config 应该也支持修改吧

@gitmkn
Copy link
Collaborator Author

gitmkn commented Apr 7, 2024

image

Copy link
Collaborator

@andrew-tx andrew-tx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrew-tx andrew-tx merged commit 10b2dc1 into master Apr 7, 2024
8 checks passed
@andrew-tx andrew-tx deleted the feat/tse-access-control branch April 7, 2024 14:17
SevenEarth pushed a commit that referenced this pull request Apr 10, 2024
* feat(tse): [115375235] support tse network access_control

* feat: add change log

* fix: modify test

* fix: modify test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants