Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tcr): [116375010]support parma regionName #2593

Merged
merged 7 commits into from
Apr 17, 2024

Conversation

WeiMengXS
Copy link
Collaborator

support parma regionName

@WeiMengXS WeiMengXS added the run check run check label Apr 17, 2024
regionId := item["region_id"].(int)
regionName := item["region_name"].(string)
if regionId == 0 && regionName != "" {
regionId = helper.StrToInt(RegionIdMap[regionName])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是不是接口支持传 regionName 呢,如果接口支持传 regionName 的话,还需要转 regionId 吗

@WeiMengXS WeiMengXS added run check run check and removed run check run check labels Apr 17, 2024
@WeiMengXS WeiMengXS added run check run check and removed run check run check labels Apr 17, 2024
Copy link
Collaborator

@andrew-tx andrew-tx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrew-tx andrew-tx merged commit 9012c6e into master Apr 17, 2024
9 checks passed
@andrew-tx andrew-tx deleted the dev/support-region-name branch April 17, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run check run check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants