Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cls): [117200212] cls index support dynamic_index params #2606

Merged
merged 3 commits into from
Apr 29, 2024
Merged

Conversation

SevenEarth
Copy link
Collaborator

cls index support dynamic_index params

@SevenEarth SevenEarth added the run check run check label Apr 29, 2024
)
id := d.Id()

immutableArgs := []string{"topic_id"}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

topic_id 不能修改这个是新加的逻辑吗

Copy link
Collaborator

@andrew-tx andrew-tx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrew-tx andrew-tx merged commit 0783d09 into master Apr 29, 2024
8 of 9 checks passed
@andrew-tx andrew-tx deleted the fix/cls branch April 29, 2024 12:56
lyu571 pushed a commit that referenced this pull request May 11, 2024
hellertang pushed a commit that referenced this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run check run check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants