Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

panic when empty ObjectPutOptions #118

Closed
pavlelee opened this issue Apr 7, 2021 · 3 comments
Closed

panic when empty ObjectPutOptions #118

pavlelee opened this issue Apr 7, 2021 · 3 comments

Comments

@pavlelee
Copy link

pavlelee commented Apr 7, 2021

image

https://github.com/tencentyun/cos-go-sdk-v5/blob/v0.7.21/object.go#L189

pointer inline struct must assert self struct not equal nil
@pavlelee
Copy link
Author

pavlelee commented Apr 7, 2021

fix pr #119

@agin719
Copy link
Collaborator

agin719 commented Apr 7, 2021

Thanks you for your pr, but it has already fixed in latest version. The func cloneObjectPutOptions has ensured that ObjectPutHeaderOptions is not nil.

@pavlelee
Copy link
Author

pavlelee commented Apr 9, 2021

Already fix in https://github.com/tencentyun/cos-go-sdk-v5/blob/v0.7.23/object.go，close pr

@pavlelee pavlelee closed this as completed Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pavlelee @agin719