Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

改进:增加对Upload part - copy API的支持 #54

Merged

Conversation

swordqiu
Copy link

改进:增加对Upload part - copy API的支持
API文档:https://cloud.tencent.com/document/product/436/8287

@swordqiu
Copy link
Author

swordqiu commented Oct 5, 2019

这个REPO没人管吗?

@agin719
Copy link
Collaborator

agin719 commented Oct 9, 2019

麻烦能添加下相关的单元测试和example吗

@swordqiu swordqiu force-pushed the feature/qj-upload-part-copy-api branch from fd3ab11 to 33d9f23 Compare October 9, 2019 15:32
@swordqiu
Copy link
Author

swordqiu commented Oct 9, 2019

麻烦能添加下相关的单元测试和example吗

已经增加单元测试和example

@swordqiu
Copy link
Author

这个PR请帮忙Review一下 /bow

@swordqiu swordqiu force-pushed the feature/qj-upload-part-copy-api branch from 33d9f23 to 47f3157 Compare October 17, 2019 01:49
@swordqiu
Copy link
Author

这个PR能合并了吗?

Copy link
Collaborator

@agin719 agin719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个PR能合并了吗?

请review一下,一些需要修改的地方已在代码中标注。

object_part.go Outdated Show resolved Hide resolved
example/object/copyPart.go Outdated Show resolved Hide resolved
object_part.go Show resolved Hide resolved
@swordqiu swordqiu force-pushed the feature/qj-upload-part-copy-api branch from 47f3157 to a239858 Compare October 28, 2019 07:09
@swordqiu
Copy link
Author

swordqiu commented Oct 28, 2019

都改了。PR已经2个多月了,review请加速~

object_part.go Show resolved Hide resolved
object_part.go Outdated Show resolved Hide resolved
@swordqiu swordqiu force-pushed the feature/qj-upload-part-copy-api branch from a239858 to 8625e74 Compare October 28, 2019 10:59
@swordqiu
Copy link
Author

resp判断nil问题已经修正

@swordqiu swordqiu force-pushed the feature/qj-upload-part-copy-api branch from 8625e74 to d9e03a3 Compare October 28, 2019 12:15
@swordqiu
Copy link
Author

header写成help的问题改好了

@swordqiu
Copy link
Author

swordqiu commented Nov 8, 2019

还是不能合并吗?

@agin719 agin719 merged commit 8ca4b37 into tencentyun:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants