This repository has been archived by the owner on Jul 15, 2018. It is now read-only.
use spf13/cobra instead of urfave/cli #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zramsay
commented
Oct 18, 2017
•
zramsay
commented
- closes consolidate binaries #95, use spf13/cobra instead of urfave/cli #101
zramsay
force-pushed
the
cobra-not-urfave
branch
from
0cdf4ef
to
8939b9f
Compare
zramsay
changed the title
This was referenced Oct 18, 2017
Closed
zramsay
force-pushed
the
cobra-not-urfave
branch
from
8939b9f
to
ec5507b
Compare
zramsay
commented
Oct 23, 2017
cmd/abci-cli/abci-cli.go
Outdated
| Use: "console", | ||
| Short: "Start an interactive abci console for multiple commands", | ||
| Long: "", | ||
| ValidArgs: []string{"batch", "echo", "info", "set_option", "deliver_tx", "check_tx", "commit", "query"}, |
There was a problem hiding this comment.
zramsay
force-pushed
the
cobra-not-urfave
branch
from
ec5507b
to
3330cb4
Compare
ebuchman
suggested changes
Oct 26, 2017
cmd/abci-cli/abci-cli.go
Outdated
| bufReader := bufio.NewReader(os.Stdin) | ||
| for { | ||
| line, more, err := bufReader.ReadLine() | ||
| if more { | ||
| return errors.New("Input line is too long") | ||
| ifExit(errors.New("Input line is too long")) |
There was a problem hiding this comment.
We should only use RunE and return errors here.
| args := persistentArgs(line) | ||
| app.Run(args) //cli prints error within its func call | ||
| pArgs := persistentArgs(line) | ||
| out, err := exec.Command(pArgs[0], pArgs[1:]...).Output() |
There was a problem hiding this comment.
shelling it out? would be better if we could keep in process
cmd/abci-cli/abci-cli.go
Outdated
| if len(args) != 1 { | ||
| return errors.New("Command check_tx takes 1 argument") | ||
| ifExit(errors.New("Command check_tx takes only 1 argument")) |
cmd/abci-cli/abci-cli.go
Outdated
| srv, err := server.NewServer(addrC, abci, app) | ||
| if err != nil { | ||
| logger.Error(err.Error()) | ||
| os.Exit(1) |
cmd/abci-cli/abci-cli.go
Outdated
| @@ -426,3 +499,10 @@ func stringOrHexToBytes(s string) ([]byte, error) { | |||
|
|
|||
| return []byte(s[1 : len(s)-1]), nil | |||
| } | |||
|
|
|||
| func ifExit(err error) { | |||
There was a problem hiding this comment.
remove this and all use of os.Exit in functions
zramsay
force-pushed
the
cobra-not-urfave
branch
from
807a4f3
to
f013ee5
Compare
ebuchman
approved these changes
Oct 27, 2017
odeke-em
added a commit
that referenced
this pull request
Dec 10, 2017
Use the single client connection at startup time for sending over commands instead of shelling out for every command. This code fixes the regression from #117 which instead used "os/exec".Command with: "abci-cli <the_command> [args...]" The purpose of this code is to restore us back to the state after cobra replace urlfave/cli. There is still a bit of work to implement Batch itself, but that should be simpler as a focused command. Fixes #133
odeke-em
added a commit
that referenced
this pull request
Dec 16, 2017
Use the single client connection at startup time for sending over commands instead of shelling out for every command. This code fixes the regression from #117 which instead used "os/exec".Command with: "abci-cli <the_command> [args...]" The purpose of this code is to restore us back to the state after cobra replace urlfave/cli. There is still a bit of work to implement Batch itself, but that should be simpler as a focused command. Fixes #133
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.