Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:duplicate proto import #117

Closed
wants to merge 1 commit into from
Closed

Conversation

clockworkgr
Copy link
Contributor

import "cosmos/base/v1beta1/coin.proto"; was imported twice so removed the duplicate.

Not really important but was breaking TS client code generation in Ignite CLI

Description

closes: #XXXX

Tasks

  • [ ]

References


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

`import "cosmos/base/v1beta1/coin.proto";` was imported twice so removed the duplicate.

Not really important but was breaking TS client code generation in Ignite CLI
@jaybxyz jaybxyz added the good first issue Good for newcomers label Sep 26, 2022
@jaybxyz
Copy link
Contributor

jaybxyz commented Sep 26, 2022

@clockworkgr Thank you for making this PR. Whenever there is a change in any *.proto files, we need to regenerate codes by $ make proto-gen. This requires you to install Docker.

@jaybxyz jaybxyz mentioned this pull request Nov 8, 2022
9 tasks
@jaybxyz
Copy link
Contributor

jaybxyz commented Nov 8, 2022

As I don't have permission to directly commit to this PR, I will work on this #117 and close this.

@jaybxyz
Copy link
Contributor

jaybxyz commented Nov 8, 2022

@clockworkgr Thank you for bringing this up!

@jaybxyz jaybxyz closed this Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants