Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add simulations #31

Merged
merged 2 commits into from
Sep 16, 2021
Merged

Conversation

dongsam
Copy link
Contributor

@dongsam dongsam commented Sep 15, 2021

Description

closes: #8

Bullet Points

  • [ ]

References


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@dongsam dongsam self-assigned this Sep 15, 2021
@codecov
Copy link

codecov bot commented Sep 16, 2021

Codecov Report

Merging #31 (3e37904) into master (5c9631b) will increase coverage by 18.17%.
The diff coverage is 85.00%.

❗ Current head 3e37904 differs from pull request most recent head dc1de84. Consider uploading reports for the commit dc1de84 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master      #31       +/-   ##
===========================================
+ Coverage   58.29%   76.47%   +18.17%     
===========================================
  Files          11       12        +1     
  Lines         223      289       +66     
===========================================
+ Hits          130      221       +91     
+ Misses         71       53       -18     
+ Partials       22       15        -7     
Impacted Files Coverage Δ
x/budget/simulation/operations.go 0.00% <0.00%> (ø)
x/budget/types/codec.go 0.00% <ø> (ø)
x/budget/types/keys.go 0.00% <0.00%> (ø)
x/budget/keeper/genesis.go 87.50% <88.88%> (+34.16%) ⬆️
x/budget/keeper/budget.go 79.74% <93.33%> (+8.31%) ⬆️
x/budget/keeper/grpc_query.go 100.00% <100.00%> (+100.00%) ⬆️
x/budget/simulation/decoder.go 100.00% <100.00%> (+80.00%) ⬆️
x/budget/types/genesis.go 100.00% <100.00%> (+18.18%) ⬆️
x/budget/types/params.go 95.55% <0.00%> (+8.88%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f1eb01...dc1de84. Read the comment docs.

@dongsam dongsam marked this pull request as ready for review September 16, 2021 09:32
@dongsam dongsam merged commit 92df17d into tendermint:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Simulation functions
1 participant