Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add emit events and update spec docs #46

Merged
merged 14 commits into from
Sep 30, 2021

Conversation

jaybxyz
Copy link
Contributor

@jaybxyz jaybxyz commented Sep 27, 2021

Description

closes: #38

Tasks

  • Add emit events and update 05_events.md
  • Update other spec docs

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@jaybxyz jaybxyz self-assigned this Sep 27, 2021
@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #46 (3e670ef) into master (b1fd562) will increase coverage by 0.68%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   79.85%   80.54%   +0.68%     
==========================================
  Files          12       12              
  Lines         283      293      +10     
==========================================
+ Hits          226      236      +10     
  Misses         42       42              
  Partials       15       15              
Impacted Files Coverage Δ
x/budget/keeper/budget.go 82.02% <100.00%> (+2.27%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1fd562...3e670ef. Read the comment docs.

@jaybxyz jaybxyz marked this pull request as ready for review September 29, 2021 06:57
Copy link
Contributor

@dongsam dongsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested some lines, could you review the suggestions?

x/budget/spec/01_concepts.md Outdated Show resolved Hide resolved
x/budget/spec/01_concepts.md Outdated Show resolved Hide resolved
x/budget/spec/01_concepts.md Outdated Show resolved Hide resolved
x/budget/spec/01_concepts.md Outdated Show resolved Hide resolved
x/budget/spec/01_concepts.md Outdated Show resolved Hide resolved
x/budget/spec/01_concepts.md Outdated Show resolved Hide resolved
x/budget/spec/01_concepts.md Outdated Show resolved Hide resolved
x/budget/spec/03_state_transitions.md Outdated Show resolved Hide resolved
x/budget/spec/04_begin_block.md Outdated Show resolved Hide resolved
x/budget/spec/04_begin_block.md Outdated Show resolved Hide resolved
Copy link
Contributor

@dongsam dongsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

x/budget/spec/03_state_transitions.md Outdated Show resolved Hide resolved
x/budget/abci.go Outdated Show resolved Hide resolved
jaybxyz and others added 2 commits September 30, 2021 17:10
Co-authored-by: dongsam <dongsamb@gmail.com>
Co-authored-by: dongsam <dongsamb@gmail.com>
@dongsam dongsam merged commit d6677f3 into tendermint:master Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Events on Spec
2 participants