Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding metrics to provide insights about the module #78

Merged
merged 8 commits into from
Nov 4, 2021

Conversation

jaybxyz
Copy link
Contributor

@jaybxyz jaybxyz commented Oct 28, 2021

Description

closes: #59

Tasks

  • Add helpful metrics to provide insights about the module

Output

# HELP budget budget
# TYPE budget gauge
budget{collection_address="cosmos1xxx",denom="stake"} 185

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@jaybxyz jaybxyz self-assigned this Oct 28, 2021
jaybxyz and others added 5 commits October 29, 2021 12:04
* main:
  docs: add -i options for sed considering os (tendermint#68)
  fix: Add govHandler on testcode for budget proposal and Fix Expired rule (tendermint#66)
  fix: panic instead of ignoring errors
@jaybxyz jaybxyz marked this pull request as ready for review November 3, 2021 03:06
x/budget/keeper/budget.go Outdated Show resolved Hide resolved
Co-authored-by: dongsam <dongsamb@gmail.com>
@jaybxyz
Copy link
Contributor Author

jaybxyz commented Nov 3, 2021

TestInitGenesis fails due to index out of range error. Let me go check and resolve it.

@jaybxyz
Copy link
Contributor Author

jaybxyz commented Nov 3, 2021

budgetsBySource.CollectionCoins[i] triggers the index out of range error because defer func() delays the execution of the function until the nearby functions return. Since the deferred func sees the recent value of i, we should add the following code inside the for loop.

i := i
collectionCoins := budgetsBySource.CollectionCoins

Copy link
Contributor

@dongsam dongsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaybxyz jaybxyz merged commit c20c700 into tendermint:main Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add metrics and telemetry
2 participants