Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

merge this back into tendermint repo. #20

Closed
tac0turtle opened this issue Apr 3, 2022 · 2 comments · Fixed by tendermint/tendermint#8468
Closed

merge this back into tendermint repo. #20

tac0turtle opened this issue Apr 3, 2022 · 2 comments · Fixed by tendermint/tendermint#8468

Comments

@tac0turtle
Copy link
Contributor

There isn't a need to keep it separate anymore, this was to avoid an issue that has since been fixed
@creachadair
Copy link
Contributor

There isn't a need to keep it separate anymore, this was to avoid an issue that has since been fixed

This seems reasonable to me. Is there an issue or any other context that explains what the original problem was, that led to the current status?

@tac0turtle
Copy link
Contributor Author

your pr fixed the issue: #16, we were not squashing so git history became huge

creachadair pushed a commit to tendermint/tendermint that referenced this issue May 5, 2022
docs: add a CI workflow to build and deploy the static site
e3ec44c 
Per tendermint/docs#20, it is no longer necessary to
build the static documentation out of a separate repository.

This change:

- Adds an actions workflow to build and deploy the docs to GitHub Pages.
- Updates some build settings in a compatible manner.

This change does not affect the existing site deployment. To complete this
change, we will need to update the custom domain pointer and disable the
corresponding workflow in the tendermint/docs repository.
creachadair pushed a commit to tendermint/tendermint that referenced this issue May 5, 2022
docs: add a CI workflow to build and deploy the static site
1626483 
Per tendermint/docs#20, it is no longer necessary to
build the static documentation out of a separate repository.

This change:

- Adds an actions workflow to build and deploy the docs to GitHub Pages.
- Updates some build settings in a compatible manner.

This change does not affect the existing site deployment. To complete this
change, we will need to update the custom domain pointer and disable the
corresponding workflow in the tendermint/docs repository. Those changes can and
must be done after this is merged.

In the future should probably also move the build rule out of the Makefile and
into the workflow directly. That will also make it easier to manage caching of
build artifacts. For now, however, I've left it as-is, so that we do not break
the active workflow on tendermint/docs, which depends on it.
@creachadair creachadair mentioned this issue May 5, 2022
Merged
3 tasks
creachadair pushed a commit to tendermint/tendermint that referenced this issue May 5, 2022
docs: add a CI workflow to build and deploy the static site
2a28003 
Per tendermint/docs#20, it is no longer necessary to
build the static documentation out of a separate repository.

This change:

- Adds an actions workflow to build and deploy the docs to GitHub Pages.
- Updates some build settings in a compatible manner.

This change does not affect the existing site deployment. To complete this
change, we will need to update the custom domain pointer and disable the
corresponding workflow in the tendermint/docs repository. Those changes can and
must be done after this is merged.

In the future should probably also move the build rule out of the Makefile and
into the workflow directly. That will also make it easier to manage caching of
build artifacts. For now, however, I've left it as-is, so that we do not break
the active workflow on tendermint/docs, which depends on it.
creachadair pushed a commit to tendermint/tendermint that referenced this issue May 5, 2022
docs: add a CI workflow to build and deploy the static site
1cbf4ca 
Per tendermint/docs#20, it is no longer necessary to
build the static documentation out of a separate repository.

This change:

- Adds an actions workflow to build and deploy the docs to GitHub Pages.
- Updates some build settings in a compatible manner.

This change does not affect the existing site deployment. To complete this
change, we will need to update the custom domain pointer and disable the
corresponding workflow in the tendermint/docs repository. Those changes can and
must be done after this is merged.

In the future should probably also move the build rule out of the Makefile and
into the workflow directly. That will also make it easier to manage caching of
build artifacts. For now, however, I've left it as-is, so that we do not break
the active workflow on tendermint/docs, which depends on it.
creachadair pushed a commit to tendermint/tendermint that referenced this issue May 6, 2022
docs: add a CI workflow to build and deploy the static site
2cde726 
Per tendermint/docs#20, it is no longer necessary to
build the static documentation out of a separate repository.

This change:

- Adds an actions workflow to build and deploy the docs to GitHub Pages.
- Updates some build settings in a compatible manner.

This change does not affect the existing site deployment. To complete this
change, we will need to update the custom domain pointer and disable the
corresponding workflow in the tendermint/docs repository. Those changes can and
must be done after this is merged.

In the future should probably also move the build rule out of the Makefile and
into the workflow directly. That will also make it easier to manage caching of
build artifacts. For now, however, I've left it as-is, so that we do not break
the active workflow on tendermint/docs, which depends on it.
creachadair pushed a commit to tendermint/tendermint that referenced this issue May 6, 2022
docs: add a CI workflow to build and deploy the static site
a214e61 
Per tendermint/docs#20, it is no longer necessary to
build the static documentation out of a separate repository.

This change:

- Adds an actions workflow to build and deploy the docs to GitHub Pages.
- Updates some build settings in a compatible manner.

This change does not affect the existing site deployment. To complete this
change, we will need to update the custom domain pointer and disable the
corresponding workflow in the tendermint/docs repository. Those changes can and
must be done after this is merged.

In the future should probably also move the build rule out of the Makefile and
into the workflow directly. That will also make it easier to manage caching of
build artifacts. For now, however, I've left it as-is, so that we do not break
the active workflow on tendermint/docs, which depends on it.
creachadair pushed a commit to tendermint/tendermint that referenced this issue May 6, 2022
Reintegrate docs deployment into the main TM repo (#8468)
97f2944 
Per tendermint/docs#20, it is no longer necessary to
build the static documentation out of a separate repository.

This change:

- Adds an actions workflow to build and deploy the docs to GitHub Pages.
- Updates some build settings in a compatible manner.

This change does not affect the existing site deployment. To complete this
change, we will need to update the custom domain pointer and disable the
corresponding workflow in the tendermint/docs repository. Those changes can and
must be done after this is merged.

In the future should probably also move the build rule out of the Makefile and
into the workflow directly. That will also make it easier to manage caching of
build artifacts. For now, however, I've left it as-is, so that we do not break
the active workflow on tendermint/docs, which depends on it.
creachadair added a commit that referenced this issue May 6, 2022
@creachadair
Disable docs deployment (moved to tendermint/tendermint).
0984cae 
Updates #20.

Context: tendermint/tendermint#8468
@creachadair creachadair mentioned this issue May 6, 2022
Merged
creachadair added a commit that referenced this issue May 6, 2022
@creachadair
Disable docs deployment (moved to tendermint/tendermint). (#24)
6c7d901 
Updates #20.

Context: tendermint/tendermint#8468
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reintegrate docs deployment into the main TM repo tendermint/tendermint
2 participants
@creachadair @tac0turtle