Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: define proper sentinel errors #163

Closed
hallazzang opened this issue Oct 12, 2021 · 1 comment · Fixed by #167
Closed

fix: define proper sentinel errors #163

hallazzang opened this issue Oct 12, 2021 · 1 comment · Fixed by #167
Assignees
@hallazzang
Labels
enhancement New feature or request
Milestone
Farming F1 v1.0

Comments

@hallazzang
Copy link
Contributor

Currently, some of defined sentinel errors are not used(such as ErrPlanNotExists, ErrRewardNotExists).
If these errors are not gonna used in the future, it'd be better to remove them.
Or, if we need them, then we should use it correctly in our code.
@hallazzang hallazzang added the enhancement New feature or request label Oct 12, 2021
@hallazzang hallazzang added this to the Farming F1 v1.0 milestone Oct 12, 2021
@hallazzang hallazzang self-assigned this Oct 12, 2021
@dongsam
Copy link
Contributor

dongsam commented Oct 12, 2021

Since it's before v1.0 release, there is no problem with backward compatibility, so I think we can remove it 👍

@hallazzang hallazzang mentioned this issue Oct 14, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hallazzang hallazzang

Labels
enhancement New feature or request
Projects
None yet
Milestone
Farming F1 v1.0
Development

Successfully merging a pull request may close this issue.

fix: refine sentinel errors hallazzang/farming
2 participants
@dongsam @hallazzang