fix: refine sentinel errors #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also update some comments
also update tests
dongsam
approved these changes
Oct 15, 2021
jaybxyz
added a commit
to jaybxyz/farming
that referenced
this pull request
Oct 15, 2021
…108-improve-sim-tests * commit 'f5ff949f16b4cc6f8a3061a0512faa3c9defb8eb': docs: apply proto-all, fix typo fix: refine sentinel errors (tendermint#167) chore: apply suggestions from code review chore: resolve tendermint#125 and fix proto lint issue docs: add swagger related files generate statik file feat: go get grpc-gateway v2 chore: add detailed descriptions and responses for all queries and update Makefile feat: add third party proto files chore: apply changes from code review docs: add swager spec for params chore: add comments for types chore: update comments for keeper docs: leave proper comments docs: update comments docs: add comments for flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove unused sentinel errors and introduce new sentinel errors.
closes: #163
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Files changedin the Github PR explorerCodecov Reportin the comment section below once CI passes