feat: fix update public plan proposal & disable codecov patch #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
==========================================
+ Coverage 69.71% 70.42% +0.71%
==========================================
Files 25 25
Lines 2262 2303 +41
==========================================
+ Hits 1577 1622 +45
+ Misses 533 518 -15
- Partials 152 163 +11
Continue to review full report at Codecov.
|
…131-fix-update-public-proposal * commit '85846bac8ea958afc14475ee32b7a5f9ae501bb8': docs: update issue, pr template docs: add bedges and update issue template test: add more test cases for edge case test: add test case for tendermint#134 chore: fix typo fix: use IsAllLTE instead of IsAllLT
|
codecov patch is not reliable and there are many issues out there proposing it to be disabled. |
dongsam
reviewed
Sep 24, 2021
dongsam
reviewed
Sep 24, 2021
4 tasks
hallazzang
suggested changes
Sep 27, 2021
…131-fix-update-public-proposal * commit '9c24552e9d7e3609e99f6803d3b98f6539267613': fix: broken link chore: fix broken links and add CONTRIBUTING.md feat: add markdown link checker workflow
hallazzang
approved these changes
Sep 27, 2021
jaybxyz
changed the title
jaybxyz
added a commit
to jaybxyz/farming
that referenced
this pull request
Sep 27, 2021
…121-add-demo-docs * commit '97b297b45a792b0ffc6616e24595c314aecf89b6': feat: fix update public plan proposal & disable codecov patch (tendermint#133) fix: broken link chore: fix broken links and add CONTRIBUTING.md feat: add markdown link checker workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #131
Tasks
References
codecov/patchis unreliable and presents weird behaviour from time to timecodecov/patchcheck issue kata-containers/tests#508Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Files changedin the Github PR explorerCodecov Reportin the comment section below once CI passes