Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix comparison bug when allocating all balances of the farming pool #135

Merged
merged 4 commits into from
Sep 24, 2021

Conversation

hallazzang
Copy link
Contributor

Description

closes: #134


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@hallazzang hallazzang self-assigned this Sep 23, 2021
@hallazzang hallazzang added bug Something isn't working and removed bug Something isn't working labels Sep 23, 2021
@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #135 (e9445ec) into master (c73ffe5) will not change coverage.
The diff coverage is 100.00%.

❗ Current head e9445ec differs from pull request most recent head a3b073c. Consider uploading reports for the commit a3b073c to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #135   +/-   ##
=======================================
  Coverage   69.71%   69.71%           
=======================================
  Files          25       25           
  Lines        2262     2262           
=======================================
  Hits         1577     1577           
  Misses        533      533           
  Partials      152      152           
Impacted Files Coverage Δ
x/farming/keeper/reward.go 88.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c73ffe5...a3b073c. Read the comment docs.

Copy link
Contributor

@dongsam dongsam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongsam dongsam added bug Something isn't working and removed bug Something isn't working labels Sep 24, 2021
@dongsam dongsam merged commit cc2de5e into tendermint:master Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Rewards are not allocated when allocating all balances of the farming pool
2 participants