fix: emit rewards_withdrawn event
#166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Keeper.WithdrawRewards` is called in several places: - `Keeper.Harvest` - `Keeper.ProcessQueuedCoins` - `Keeper.Unstake` so instead of emitting `harvest` event in `Keeper.Harvest`, emit `rewards_withdrawn` event in these places. note that this new event will be emitted multiple times for a farmer(for each staking coin denom the farmer has).
dongsam
suggested changes
Oct 14, 2021
There was a problem hiding this comment.
Could you update the spec doc also?
https://github.com/tendermint/farming/blob/3323424035b17550fe5915c67d2f7d4b0a7221a7/x/farming/spec/06_events.md
instead of `reward_coins` attribute, use `staking_coin_denoms`
dongsam
added a commit
to dongsam/farming
that referenced
this pull request
Oct 21, 2021
* commit '305f2fb7da43f1050dd6aa591b43bbdadefa63bd': (23 commits) chore: bump Cosmos SDK version to 0.44.2 fix: emit `rewards_withdrawn` event (tendermint#166) chore: fix linter issue feat: refactor validating EpochAmount, EpochRatio feat: refactory ValidateStakingCoinTotalWeights fix: apply suggestions from review fix: terminate plan when deleting public plan proposal (tendermint#162) fix: change the logic to determine what the request is for chore: fix typo and use nil EpochRatio instead of zero chore: change error message test: update proposal handler tests fix: allow optional fields in UpdateRequestProposal fix: more strict validation and allow optional addrs fix: EpochAmount/EpochRatio fields can be both empty fix: allow empty plan name in UpdateRequestProposal fix!: forbid empty plan name and allow empty weights test: change expected error messages test: add tests for proposal validation test: add TestValidateStakingCoinTotalWeights fix: fix proposal validation logic ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Keeper.WithdrawRewardsis called in several places:Keeper.HarvestKeeper.ProcessQueuedCoinsKeeper.Unstakeso instead of emitting
harvestevent inKeeper.Harvest,emit
rewards_withdrawnevent in these places.note that this new event will be emitted
multiple times for a farmer(for each staking coin denom
the farmer has).
closes: #164
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Files changedin the Github PR explorerCodecov Reportin the comment section below once CI passes