feat: impose DelayedStakingGasFee when staking #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See tendermint#102 for details
dongsam
reviewed
Oct 15, 2021
|
Oh, we missed upgrading Swagger version on this PR, let me upgrade swagger on #176 |
dongsam
reviewed
Oct 18, 2021
| } | ||
|
|
||
| params := k.GetParams(ctx) |
There was a problem hiding this comment.
Sorry for additional review,
How about
if numStakingCoinDenoms > 0 {
params := k.GetParams(ctx)
ctx.GasMeter().ConsumeGas(sdk.Gas(numStakingCoinDenoms)*params.DelayedStakingGasFee, "DelayedStakingGasFee")
}
and could you add comments for a link or description of DelayedStakingGasFee
Comment on lines
+26
to
+31
|
|
||
| Since the farming module has adopted delayed staking, | ||
| handling `MsgStake` does not immediately consumes gas. | ||
| Instead, gas for this newly queued staking is consumed at the end of the epoch. | ||
| `DelayedStakingGasFee` is to impose gas fee for this reason. |
There was a problem hiding this comment.
Could you describe it in more detail? We can commit on #178 continuously @hallazzang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See #102.
closes: #102
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Files changedin the Github PR explorerCodecov Reportin the comment section below once CI passes