Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: emit rewards_withdrawn only when positive amount is withdrawn #181

Merged

Conversation

hallazzang
Copy link
Contributor

Description

Currently, rewards_withdraw event is emitted whenever WithdrawRewards is called.
Fix this to only emit event when positive rewards amount is withdrawn.

if !rewards.IsZero() {
if !truncatedRewards.IsZero() {
if err := k.bankKeeper.SendCoins(ctx, k.GetRewardsReservePoolAcc(ctx), farmerAcc, truncatedRewards); err != nil {
return nil, err
}
}
k.DecreaseOutstandingRewards(ctx, stakingCoinDenom, rewards)
}
staking.StartingEpoch = currentEpoch
k.SetStaking(ctx, stakingCoinDenom, farmerAcc, staking)
ctx.EventManager().EmitEvents(sdk.Events{
sdk.NewEvent(
types.EventTypeRewardsWithdrawn,
sdk.NewAttribute(types.AttributeKeyFarmer, farmerAcc.String()),
sdk.NewAttribute(types.AttributeKeyStakingCoinDenom, stakingCoinDenom),
sdk.NewAttribute(types.AttributeKeyRewardCoins, truncatedRewards.String()),
),
})


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@hallazzang hallazzang added the bug Something isn't working label Oct 18, 2021
@hallazzang hallazzang self-assigned this Oct 18, 2021
@dongsam dongsam added this to the Farming F1 v1.0 milestone Oct 18, 2021
@dongsam dongsam merged commit a40de72 into tendermint:master Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants