Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: edit budget_with_farming.md demo text #210

Merged
merged 7 commits into from
Nov 5, 2021
Merged

Conversation

barriebyron
Copy link
Contributor

changes for grammar and consistent audience "you"

see the Technical content style guidance for Farming

most of the changes here tightened up language, provide consistency, changed audience to "you"

good job! I did not run the demo, so I verify only the language

Description

closes: #XXXX

Tasks

  • [ ]

References


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Appropriate labels applied
  • Targeted PR against correct branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

changes for grammar and consistent audience "you"
Copy link
Contributor Author

@barriebyron barriebyron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestions for clarity around code fences and output of commands

good work for the demo!

docs/Tutorials/demo/budget_with_farming.md Show resolved Hide resolved
Copy link
Contributor

@jaybxyz jaybxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As always, we appreciate you for taking the time to review the docs. They are really valuable feedbacks and suggestions. I left some comments and replied to your questions.

docs/Tutorials/demo/budget_with_farming.md Outdated Show resolved Hide resolved
docs/Tutorials/demo/budget_with_farming.md Outdated Show resolved Hide resolved
docs/Tutorials/demo/budget_with_farming.md Show resolved Hide resolved
docs/Tutorials/demo/budget_with_farming.md Outdated Show resolved Hide resolved
docs/Tutorials/demo/budget_with_farming.md Outdated Show resolved Hide resolved
docs/Tutorials/demo/budget_with_farming.md Show resolved Hide resolved
docs/Tutorials/demo/budget_with_farming.md Show resolved Hide resolved
docs/Tutorials/demo/budget_with_farming.md Outdated Show resolved Hide resolved
@barriebyron
Copy link
Contributor Author

thank you @kogisin make any changes required and commit at will, great improvements!

Barrie Byron and others added 4 commits November 3, 2021 23:58
Co-authored-by: JayB <jaybkim2@gmail.com>
Co-authored-by: JayB <jaybkim2@gmail.com>
Co-authored-by: JayB <jaybkim2@gmail.com>
Co-authored-by: JayB <jaybkim2@gmail.com>
@jaybxyz jaybxyz merged commit fedca46 into main Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants