-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: edit budget_with_farming.md demo text #210
Conversation
changes for grammar and consistent audience "you"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestions for clarity around code fences and output of commands
good work for the demo!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As always, we appreciate you for taking the time to review the docs. They are really valuable feedbacks and suggestions. I left some comments and replied to your questions.
thank you @kogisin make any changes required and commit at will, great improvements! |
Co-authored-by: JayB <jaybkim2@gmail.com>
Co-authored-by: JayB <jaybkim2@gmail.com>
Co-authored-by: JayB <jaybkim2@gmail.com>
Co-authored-by: JayB <jaybkim2@gmail.com>
changes for grammar and consistent audience "you"
see the Technical content style guidance for Farming
most of the changes here tightened up language, provide consistency, changed audience to "you"
good job! I did not run the demo, so I verify only the language
Description
closes: #XXXX
Tasks
References
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes