Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement chain-specific keyrings (closes #231, #111) #232

Merged
merged 1 commit into from Apr 19, 2019

Conversation

@tarcieri
Copy link
Collaborator

commented Apr 18, 2019

Moves from a single global keyring to chain-specific keyrings, where keys/signers can be potentially shared across chains if desired.

This enables true multitenancy for supporting multiple chains with a single KMS instance, and resolves lingering questions around the access control model, namely that each connection has an associated chain ID, and signing operations are isolated to that chain's keyring.

Implement chain-specific keyrings (closes #231, #111)
Moves from a single global keyring to chain-specific keyrings, where
keys/signers can be potentially shared across chains if desired.

This enables true multitenancy for supporting multiple chains with a
single KMS instance, and reloves lingering questions around the access
control model, namely that each connection has an associated chain ID,
and signing operations are isolated to that chain's keyring.
@liangping

This comment has been minimized.

Copy link

commented Apr 18, 2019

awesome. save a lot of money for us.

@Liamsi

Liamsi approved these changes Apr 19, 2019

Copy link
Member

left a comment

utACK

@tarcieri tarcieri merged commit 74e934b into master Apr 19, 2019

1 check passed

ci/circleci Your tests passed on CircleCI!
Details

@tarcieri tarcieri deleted the chain-specific-keyrings branch Apr 19, 2019

@tarcieri tarcieri referenced this pull request Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.