This repository has been archived by the owner on Jun 3, 2020. It is now read-only.
Use an initial height of 0 in default chain state (fixes #369) #373
+30
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that `tendermint-rs` v0.11 is out, we can use a default chain height of zero for chains which are in the initial state. This bit us yesterday on the `cosmoshub-3` upgrade.
zmanian
approved these changes
Dec 12, 2019
tarcieri
commented
Dec 12, 2019
| fn write_initial_state(path: &Path) -> Result<Self, Error> { | ||
| let mut consensus_state = consensus::State::default(); | ||
|
|
||
| // TODO(tarcieri): correct upstream `tendermint-rs` default height to 0 |
There was a problem hiding this comment.
Would be good to change this upstream in tendermint-rs, then we can just rely on consensus::State::default()
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that
tendermint-rsv0.11 is out, we can use a default chain height of0for chains which are in the initial state (previously it was disallowed).This bit us yesterday on the
cosmoshub-3upgrade.