Skip to content
This repository has been archived by the owner on Feb 23, 2022. It is now read-only.

proto: have a single source of truth #343

Closed
2 of 4 tasks
tac0turtle opened this issue Aug 31, 2021 · 1 comment · Fixed by tendermint/tendermint#6976
Closed
2 of 4 tasks

proto: have a single source of truth #343

tac0turtle opened this issue Aug 31, 2021 · 1 comment · Fixed by tendermint/tendermint#6976

Comments

@tac0turtle
Copy link
Contributor

tac0turtle commented Aug 31, 2021 •
edited

Summary

There are two locations for proto files. Tendermint and this repo. We should converge to a single location. I propose we remove the proto files from tendermint, only house them in the spec, then edit the script for generating go files to read the proto files from the spec repo.

Actions

  • edit protobuf generation script to use proto files from this repo
  • Add docs on how to change the script to test local changes if not present in the spec
  • delete proto files from tendermint/tendermint
  • win
@tac0turtle tac0turtle mentioned this issue Sep 23, 2021
Merged
mergify bot pushed a commit to tendermint/tendermint that referenced this issue Oct 18, 2021
@tac0turtle
tools: clone proto files from spec (#6976)
19ec4a5 
## Description

clone proto files from spec in order to have them in a single location

closes tendermint/spec#343
@evan-forbes evan-forbes mentioned this issue Oct 22, 2021
Closed
NexZhu pushed a commit to daotl/go-acei that referenced this issue Oct 27, 2021
@tac0turtle
tools: clone proto files from spec (#6976)
70537fc 
## Description

clone proto files from spec in order to have them in a single location

closes tendermint/spec#343
@cmwaters
Copy link
Contributor

Can we close this issue yet or are there remaining items that need to be completed?

evan-forbes pushed a commit to celestiaorg/celestia-core that referenced this issue Feb 2, 2022
@tac0turtle @evan-forbes
tools: clone proto files from spec (#6976)
65b93eb 
## Description

clone proto files from spec in order to have them in a single location

closes tendermint/spec#343
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tools: clone proto files from spec tendermint/tendermint
2 participants
@tac0turtle @cmwaters