This repository has been archived by the owner on Feb 23, 2022. It is now read-only.
proto: merge the proposer-based timestamps parameters #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* proto: rename timing params to synchrony params
williambanfield
requested review from
ebuchman,
josef-widder,
konnov and
milosevic
as code owners
creachadair
approved these changes
Jan 31, 2022
proto/tendermint/types/params.proto
Outdated
| // see the specification of proposer-based timestamps: | ||
| // https://github.com/tendermint/spec/tree/master/spec/consensus/proposer-based-timestamp | ||
| message SynchronyParams { | ||
| // message_delay bounds how long a proposal message may take to reach all validators on a newtork |
There was a problem hiding this comment.
The indentation here appears a little wonky. Tabs?
cmwaters
approved these changes
Feb 1, 2022
|
Is this the only place we mention |
sergio-mena
pushed a commit
that referenced
this pull request
Feb 4, 2022
evan-forbes
pushed a commit
to celestiaorg/spec
that referenced
this pull request
Feb 10, 2022
This was referenced Jan 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These parameters were previously merged into the proposer-based timestamps long-lived branch.
This pull request merges these parameters into the main branch and updates the proto files to include documentation.