This repository has been archived by the owner on Feb 23, 2022. It is now read-only.
Move light specs to their own dir, add readme and diagram #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ebuchman
commented
Jan 22, 2020
ebuchman
commented
- fork-accountability.md -> light/accountability.md
- light-client.md -> light/verification.md
- non-recursive-light-client.md -> light/verification-non-recursive.md
- new detection.md with a TODO
- new README outlining the motivation and structure, including the light node diagram
- update consensus/README with an index
liamsi
reviewed
Jan 22, 2020
|
|
||
| Tendermint consensus guarantees the following specifications for all heights: | ||
| * agreement -- no two correct full nodes decide differently. | ||
| * validity -- the decided block satisfies the predefined predicate *valid()*. |
There was a problem hiding this comment.
Nit regarding formatting: should we format this as valid() instead of valid()? (consistently, here and everywhere else).
Suggested change
| * validity -- the decided block satisfies the predefined predicate *valid()*. | |
| * validity -- the decided block satisfies the predefined predicate `valid()`. |
liamsi
reviewed
Jan 22, 2020
| @@ -0,0 +1,612 @@ | |||
| # Lite client | |||
There was a problem hiding this comment.
Suggested change
| # Lite client | |
| # Light client |
liamsi
reviewed
Jan 22, 2020
| @@ -0,0 +1,612 @@ | |||
| # Lite client | |||
|
|
|||
| A lite client is a process that connects to Tendermint full node(s) and then tries to verify application | |||
There was a problem hiding this comment.
Suggested change
| A lite client is a process that connects to Tendermint full node(s) and then tries to verify application | |
| A light client is a process that connects to Tendermint full node(s) and then tries to verify application |
liamsi
reviewed
Jan 22, 2020
| NextValidatorsHash []byte // hash of the validators for the next block | ||
|
|
||
| // hashes of block data | ||
| LastCommitHash []byte // hash of the commit from validators from the last block |
There was a problem hiding this comment.
Suggested change
| LastCommitHash []byte // hash of the commit from validators from the last block | |
| LastCommitHash []byte // hash of the commit from validators from the last block |
milosevic
approved these changes
Jan 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.