Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and improve TestApplyRequest #944

Open
lumtis opened this issue Aug 31, 2022 · 0 comments
Open

Refactor and improve TestApplyRequest #944

lumtis opened this issue Aug 31, 2022 · 0 comments
Labels
launch Related to launch module test Improve tests

Comments

@lumtis
Copy link
Contributor

lumtis commented Aug 31, 2022 •
edited
Loading

Part of #855

Creating a specific issue as this particular test file should be handled in a specific PR

We should follow guidelines of #556 for TestApplyRequest in x/launch/keeper/request_test.go

The current structure using sample.AllRequestContents is hard to maintain and not visual

Consider improving TestCheckRequest as well
@lumtis lumtis added test Improve tests launch Related to launch module labels Aug 31, 2022
@lumtis lumtis mentioned this issue Aug 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
launch Related to launch module test Improve tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lumtis