address discrepancies between spec and implementation (#322)

tendermint · Jul 16, 2021 · 24f22ee · 24f22ee
1 parent f790b6f
commit 24f22ee
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/spec/light-client/detection/detection_003_reviewed.md b/spec/light-client/detection/detection_003_reviewed.md
@@ -457,6 +457,10 @@ we refer to a variable of the following type
 type LightClientAttackEvidence struct {
     ConflictingBlock   LightBlock
     CommonHeight       int64
+
+    // Evidence also includes application specific data which is not
+    // part of verification but is sent to the application once the
+    // evidence gets committed on chain.
 }
 ```
 
@@ -698,6 +702,10 @@ func CreateEvidenceForPeer(peer PeerID, root LightBlock, trace LightStore)
                 // we can create evidence for submission to the secondary
                 ev := new InternalEvidence;
                 ev.Evidence.ConflictingBlock := trace[i];
+                // CommonHeight is used to indicate the type of attack
+                // if the CommonHeight != ConflictingBlock.Height this 
+                // is by definition a lunatic attack else it is an
+                // equivocation attack
                 ev.Evidence.CommonHeight := common.Height;
                 ev.Peer := peer
                 return (ev, common, auxLS, FoundEvidence)

diff --git a/spec/light-client/verification/verification_001_published.md b/spec/light-client/verification/verification_001_published.md
@@ -472,8 +472,6 @@ type LightBlock struct {
   Header          Header
   Commit          Commit
   Validators      ValidatorSet
-  NextValidators  ValidatorSet
-  Provider        PeerID
 }
 ```
 

diff --git a/spec/light-client/verification/verification_002_draft.md b/spec/light-client/verification/verification_002_draft.md
@@ -486,8 +486,6 @@ type LightBlock struct {
   Header          Header
   Commit          Commit
   Validators      ValidatorSet
-  NextValidators  ValidatorSet
-  Provider        PeerID
 }
 ```