Skip to content

Commit

Permalink
disable mempool WAL by default (#2490)
Browse files Browse the repository at this point in the history
  • Loading branch information
melekes authored and ebuchman committed Sep 28, 2018
1 parent 8dda3c3 commit 47bc15c
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG_PENDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Special thanks to external contributors on this release:
BREAKING CHANGES:

* CLI/RPC/Config
- [config] `mempool.wal` is disabled by default

* Apps

Expand Down
2 changes: 1 addition & 1 deletion config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@ func DefaultMempoolConfig() *MempoolConfig {
Recheck: true,
RecheckEmpty: true,
Broadcast: true,
WalPath: filepath.Join(defaultDataDir, "mempool.wal"),
WalPath: "",
// Each signature verification takes .5ms, size reduced until we implement
// ABCI Recheck
Size: 5000,
Expand Down
4 changes: 4 additions & 0 deletions docs/tendermint-core/running-in-production.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,10 @@ propose it. Clients must monitor their txs by subscribing over websockets,
polling for them, or using `/broadcast_tx_commit`. In the worst case, txs can be
resent from the mempool WAL manually.

For the above reasons, the `mempool.wal` is disabled by default. To enable, set
`mempool.wal_dir` to where you want the WAL to be located (e.g.
`data/mempool.wal`).

## DOS Exposure and Mitigation

Validators are supposed to setup [Sentry Node
Expand Down

0 comments on commit 47bc15c

Please sign in to comment.