unlock mtx right after we select true indices

tendermint · Oct 4, 2018 · 5268d68 · 5268d68
1 parent 481b5b6
commit 5268d68
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/libs/common/bit_array.go b/libs/common/bit_array.go
@@ -241,17 +241,16 @@ func (bA *BitArray) PickRandom() (int, bool) {
 	if bA == nil {
 		return 0, false
 	}
-	bA.mtx.Lock()
 
+	bA.mtx.Lock()
 	trueIndices := bA.getTrueIndices()
-	// no bits set to true
-	if len(trueIndices) == 0 {
+	bA.mtx.Unlock()
+
+	if len(trueIndices) == 0 { // no bits set to true
 		return 0, false
 	}
-	index := trueIndices[RandIntn(len(trueIndices))]
 
-	bA.mtx.Unlock()
-	return index, true
+	return trueIndices[RandIntn(len(trueIndices))], true
 }
 
 func (bA *BitArray) getTrueIndices() []int {