Skip to content

Commit

Permalink
Remove CGO_ENABLED=0 from make install
Browse files Browse the repository at this point in the history
It was writing to stdlib packages net, x/crypto, etc. and failing when it didn't have write access to them (which it often shouldn't)

Fixes issue #941

Explained in golang issue: golang/go#18981 (fixed in develop/1.10)
  • Loading branch information
ethanfrey committed Dec 8, 2017
1 parent b98098b commit 9657d18
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions Makefile
Expand Up @@ -12,13 +12,13 @@ BUILD_FLAGS = -ldflags "-X github.com/tendermint/tendermint/version.GitCommit=`g
all: get_vendor_deps install test

install:
CGO_ENABLED=0 go install $(BUILD_FLAGS) ./cmd/tendermint
go install $(BUILD_FLAGS) ./cmd/tendermint

build:
CGO_ENABLED=0 go build $(BUILD_FLAGS) -o build/tendermint ./cmd/tendermint/
go build $(BUILD_FLAGS) -o build/tendermint ./cmd/tendermint/

build_race:
CGO_ENABLED=0 go build -race $(BUILD_FLAGS) -o build/tendermint ./cmd/tendermint
go build -race $(BUILD_FLAGS) -o build/tendermint ./cmd/tendermint

# dist builds binaries for all platforms and packages them for distribution
dist:
Expand Down

0 comments on commit 9657d18

Please sign in to comment.